Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Documents containing dataframes in Multilabel constructor #3237

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Sep 19, 2022

Related Issues

Proposed Changes:

Convert Document's contents to str in the constructor when building contexts

How did you test it?

A unit test reproducing the problem was added to this PR

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner September 19, 2022 08:09
@masci masci requested review from vblagoje and removed request for a team September 19, 2022 08:09
@masci masci added the type:bug Something isn't working label Sep 19, 2022
@masci masci requested a review from a team as a code owner September 19, 2022 09:44
@vblagoje
Copy link
Member

@masci looks good, but how is the change related to the "Proposed Changes" section?

@masci masci merged commit 8fbccbd into main Sep 19, 2022
@masci masci deleted the massi/multilabel branch September 19, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants