Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix Windows CI #3222

Merged
merged 7 commits into from
Sep 16, 2022
Merged

chore: fix Windows CI #3222

merged 7 commits into from
Sep 16, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Sep 15, 2022 •
edited
Loading

Related Issues

Proposed Changes:

Pin OpenJDK to latest 11 available

How did you test it?

CI

Notes for the reviewer

Checklist

@masci masci marked this pull request as ready for review September 15, 2022 14:16
@masci masci requested a review from a team as a code owner September 15, 2022 14:16
@masci masci requested review from bogdankostic and removed request for a team September 15, 2022 14:16
@masci masci changed the title ci win chore: fix Windows CI Sep 15, 2022
@masci masci requested review from ZanSara and removed request for bogdankostic September 15, 2022 14:24
ZanSara
ZanSara suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found only a pair of tasks which look flipped, the rest seems good! 👍

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@masci masci requested a review from ZanSara September 15, 2022 17:24
ZanSara
ZanSara approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masci masci merged commit 4ddeb7b into main Sep 16, 2022
@masci masci deleted the massi/win branch September 16, 2022 11:08
brandenchan pushed a commit that referenced this pull request Sep 21, 2022
@masci @brandenchan
chore: fix Windows CI (#3222)
a5d3f3e 
* replicate issue

* pin openjdk version

* not sure it's needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
topic:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch on Windows fails to setup in CI
2 participants
@masci @ZanSara