Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give default index for torch.device('cuda') in initialize_device_settings #3161

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Sep 5, 2022

Related Issues

Proposed Changes:

Specify the default index for the cuda device.

How did you test it?

I tested this on AWS by running the code snippet in given in issue #3160

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner September 5, 2022 15:01
@sjrl sjrl requested review from masci and vblagoje and removed request for a team September 5, 2022 15:01
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vblagoje vblagoje self-requested a review September 6, 2022 07:02
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's integrate this one 🚀

@sjrl sjrl merged commit 20c2320 into main Sep 6, 2022
@sjrl sjrl deleted the issue-3160 branch September 6, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect device specified when using HF transformer pipeline object
2 participants