Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use random_sample instead of ndarray for random array in OpenSearchDocumentStore test #3083

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR makes a small change to TestOpenSearchDocumentStore by creating query_emb using np.random.random_sample instead of numpy.ndaray. This makes sure that there are no nan values in query_emb.

How did you test it?

I let the tests for OpenSearchDocumentStore run.

Checklist

@bogdankostic bogdankostic marked this pull request as ready for review August 22, 2022 10:42
@bogdankostic bogdankostic requested a review from a team as a code owner August 22, 2022 10:42
@bogdankostic bogdankostic requested review from vblagoje and removed request for a team August 22, 2022 10:42
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @bogdankostic

@vblagoje vblagoje merged commit b03de53 into main Aug 22, 2022
@vblagoje vblagoje deleted the fix_opensearch_tests branch August 22, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants