refactor: update package metadata #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
masci
suggested changes
Aug 21, 2022
| COVERAGE_FILE = test-reports/.coverage | ||
| PYTEST_ADDOPTS = --junitxml=test-reports/{envname}/junit.xml -vv | ||
| commands = | ||
| coverage run --source haystack --parallel-mode -m pytest {posargs} |
masci
added
type:refactor
masci
approved these changes
Aug 21, 2022
ZanSara
suggested changes
Aug 22, 2022
ZanSara
reviewed
Aug 22, 2022
pyproject.toml
Outdated
Comment on lines
245
to
249
| include = [ | ||
| "/haystack", | ||
| "/rest_api", | ||
| "/VERSION.txt", | ||
| ] |
There was a problem hiding this comment.
I don't think we need to ship the REST API with the package (probably now they're shipped even if they shouldn't). On the other hand, we should rather include LICENSE?
Suggested change
| include = [ | |
| "/haystack", | |
| "/rest_api", | |
| "/VERSION.txt", | |
| ] | |
| include = [ | |
| "/haystack", | |
| "/LICENSE", | |
| "/VERSION.txt", | |
| ] |
There was a problem hiding this comment.
Licenses are always included https://hatch.pypa.io/latest/plugins/builder/sdist/#default-file-selection
Removed! Yes I was following sdist on PyPI:
ZanSara
approved these changes
Aug 22, 2022
|
Happy to help! Cool project btw 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Hello there! The Python packaging ecosystem has standardized on the interface for build backends (PEP 517/PEP 660) and the format for metadata declaration (PEP 621/PEP 631). As a result, the execution of
setup.pyfiles is now deprecated.So, I'm spending my free time updating important projects so that they are modernized and set an example for others 😄
Proposed Changes
This implements PEP 621, obviating the need for
setup.pyandsetup.cfg. The build backendhatchling(of which I am a maintainer in the PyPA) is now used as that is the default in the official Python packaging tutorial. Hatchling is available on all the major distribution channels such as Debian, Fedora, Arch Linux, conda-forge, Nixpkgs, Alpine Linux, FreeBSD/OpenBSD, Gentoo Linux, MacPorts, OpenEmbedded, Spack, etc.How did you test it?
Notes for the reviewer
*.egg-infofrompython setup.py develop; this is now fixedtoxagainChecklist