Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add progressbar to upload_files() for deepset Cloud client #3069

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

tholor
Copy link
Member

@tholor tholor commented Aug 19, 2022

Proposed Changes:

Add a tqdm progress bar to upload_files() so that users get an better idea of the progress and remaining time until their files are uploaded to deepset Cloud.

How did you test it?

Manual testing

Notes for the reviewer

Tiny change to have a standard progress bar

Checklist

@tholor tholor requested a review from a team as a code owner August 19, 2022 12:31
@tholor tholor requested review from bogdankostic and removed request for a team August 19, 2022 12:31
Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tholor tholor merged commit 76af044 into main Aug 23, 2022
@tholor tholor deleted the progress_dc_upload branch August 23, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants