Fix _debug info getting lost for previous nodes when using join nodes #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstadel
added
type:bug
julian-risch
approved these changes
Jul 7, 2022
Krak91
pushed a commit
to Krak91/haystack
that referenced
this pull request
Jul 26, 2022
…deepset-ai#2776) * fix debug output for pipelines with join nodes * add test * Update Documentation & Code Style Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
_debuginfo of previous nodes when handling join nodesAdditional context:
This leads to losing eval data on the previous nodes during pipeline.eval().
Pre-flight checklist
/cc @wochinge @erendabanlioglu