Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin es client to include bugfixes #2735

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Pin es client to include bugfixes #2735

merged 1 commit into from
Jun 27, 2022

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 26, 2022

Related Issue(s): fixes #2628

Proposed changes:

  • Pin es client so to include bugfixes for the 7.10 release line

Pre-flight checklist

scikit-learn>=1.0.0

# Metrics and logging
seqeval
mlflow

# Elasticsearch
elasticsearch>=7.7,<=7.10
elasticsearch>=7.7,<7.11
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual change, the rest is formatting fixes

@masci masci mentioned this pull request Jun 26, 2022
@masci masci requested a review from julian-risch June 27, 2022 08:52
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I wonder whether the trailing whitespaces were added by some automated bump version tool. I don't think that they were manually added. Let's keep an eye open

@masci masci merged commit 1e01cd0 into master Jun 27, 2022
@masci masci deleted the massi/es-7.11 branch June 27, 2022 13:13
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility of python 3.10 and elasticsearch 7.10 with Haystack 1.5
2 participants