Fix audio tests on CI #2718
Merged
Fix audio tests on CI #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
changed the title
ZanSara
added
type:bug
masci
approved these changes
Jun 24, 2022
1 task
Krak91
pushed a commit
to Krak91/haystack
that referenced
this pull request
Jul 26, 2022
* Update Documentation & Code Style * fix huggingface-hub version Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): https://github.com/deepset-ai/haystack/runs/7021791309?check_suite_focus=true
Analysis:
Starting point: #2700 (comment)
Upon investigation, it seems like both
espnet-model-zooandhuggingface-hub(both latest releases) are behaving properly here. However, I noticed that audio dependencies were not re-installed when running unit tests, and although I believe this should have caused a different failure, I am going to fix that in the workflow file first.