Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade transformers to 4.20.0 #2694

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Jun 21, 2022

Proposed changes:

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code

@julian-risch julian-risch requested a review from tstadel June 21, 2022 08:10
@julian-risch julian-risch marked this pull request as ready for review June 21, 2022 08:10
@tstadel
Copy link
Member

tstadel commented Jun 21, 2022

@julian-risch do we plan to add the new big model inference params like device_map to FARMReader and other components in a separate PR?

@julian-risch
Copy link
Member Author

@tstadel I think we should do that yes. We'll have a workshop on large language models next week so that can be a small PR there and we can also test it there.

@julian-risch
Copy link
Member Author

As far as I can tell the failing tests are not related to this PR but to #2657 and #2664

Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julian-risch julian-risch merged commit 4a63707 into master Jun 21, 2022
@julian-risch julian-risch deleted the transformers-upgrade-420 branch June 21, 2022 15:23
julian-risch added a commit that referenced this pull request Jun 21, 2022
julian-risch added a commit that referenced this pull request Jun 21, 2022
@julian-risch julian-risch added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 21, 2022
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
Krak91 pushed a commit to Krak91/haystack that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants