Add update_document_meta to InMemoryDocumentStore
#2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing |
tstadel
requested changes
Jul 7, 2022
| @@ -480,6 +480,19 @@ def get_document_count( | |||
| ) | |||
| return len(documents) | |||
|
|
|||
| def update_document_meta(self, id: str, meta: Dict[str, Any], index: str = None): | |||
There was a problem hiding this comment.
Can we make that now an abstractmethod of BaseDocumentStore? I think the only document store that does not support it would be DeepsetCloudDocumentStore and given its read-only nature that is not a show-stopper here.
There was a problem hiding this comment.
Added it to BaseDocumentStore
…e' into update_doc_meta_for_inmemdocstore
|
@bogdankostic The breaking change tag is because of the changed order of args within ElasticsearchDocumentStore's implementation, right? |
Yes, exactly. |
Krak91
pushed a commit
to Krak91/haystack
that referenced
this pull request
Jul 26, 2022
* Add update_document_meta to InMemoryDocumentStore * Fix typo * Update Documentation & Code Style * Add update_document_meta to BaseDocumentStore * Update Documentation & Code Style * Fix mypy * Update Documentation & Code Style * Add update_document_meta to MockDocumentStore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
InMemoryDocumentStorewas the only DocumentStore that did not supportupdate_document_meta. This PR adds theupdate_document_metamethod to theInMemoryDocumentStore.Status (please check what you already did):
Breaking Change
As we added
update_document_metatoBaseDocumentStore, we needed to change the signature ofupdate_document_metainElasticsearchDocumentStore.