Make check of document & embedding count optional in FAISS and Pinecone #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
changed the title
bogdankostic
approved these changes
Jun 24, 2022
Krak91
pushed a commit
to Krak91/haystack
that referenced
this pull request
Jul 26, 2022
…ne (deepset-ai#2677) * make validation optional & add method call in pinecone init * Update Documentation & Code Style Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
_validate_index_sync()method in FAISS and Pinecone hinders users from initializing a document store that already contains some documents but no embeddings yet. This situation can happen though if a large number of documents is written to the document store in multiple separate sessions and only after all documents are written, theupdate_embeddingsstep is called. This PR makes running the validation optional by adding a parameter to the document store'sinitmethod that allows choosing whether to run it or not. Default isTrue._validate_index_sync()but it was never called. This PR calls it as the final step of the document store's initmethodStatus (please check what you already did):