Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include meta data when computing embeddings in EmbeddingRetriever #2559

Merged
merged 6 commits into from
May 17, 2022

Conversation

MichelBartels
Copy link
Contributor

Proposed changes:
The TableTextRetriever already concatenates the meta data and the content when computing embeddings. This PR adds this functionality to the EmbeddingRetriever.

Status (please check what you already did):

Copy link
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelBartels MichelBartels merged commit a952ba2 into master May 17, 2022
@MichelBartels MichelBartels deleted the embedding-retriever-meta-data branch May 17, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants