set top_k to 5 in SAS to be consistent #2550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-The change refers to the top_k value of the retriever in the Advanced Evaluation Metrics in the Tutorial5_Evaluation.py.
The actual value is set to 1 which is both suboptimal and inconsistent with all the previous utilized values of top_k for the retriever (equal to 5). Trying the script with other values leads to better SAS results. For example, setting it to 5 (to be consistent with the previous values) results in 0.528 compared to 0.443 using top_k = 1.