Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image tag with semantic version for releases #2548

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

askainet
Copy link
Contributor

The current GHA workflow that builds and pushes docker images is configured to add a tag with the haystack version to the images when there is a new release, but this version tag is never created.

Proposed changes:

  • Add the missing trigger to the docker_build GHA workflow so it runs also when creating tags in the git repository, i.e. on a new version release.
  • Replace the docker image tag based on the raw git tag for a rule handling semantic versions.
  • Update versions of actions docker/metadata-action and docker/build-push-action.

Status (please check what you already did):

@askainet askainet requested a review from ArzelaAscoIi May 13, 2022 20:15
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :) Could we somehow rerun this for v1.4.0 or should we manually publish an image ?

@askainet
Copy link
Contributor Author

Nice! :) Could we somehow rerun this for v1.4.0 or should we manually publish an image ?

@ArzelaAscoIi I've manually pushed deepset/haystack-gpu:minimal-1.4.0 tag for the commit hash of v1.4.0 release 081b886

@askainet askainet merged commit a2a99f7 into master May 16, 2022
@askainet askainet deleted the docker-semver branch May 16, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants