Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenSearchDocumentStore's __init__ #2498

Merged
merged 3 commits into from
May 5, 2022
Merged

Fix OpenSearchDocumentStore's __init__ #2498

merged 3 commits into from
May 5, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented May 4, 2022

Closes #2492

@ZanSara ZanSara changed the title Fix OpenSearchDocumentStore's __init__ Fix OpenSearchDocumentStore's __init__ May 4, 2022
@julian-risch julian-risch self-requested a review May 4, 2022 15:44
@julian-risch
Copy link
Member

@ZanSara the test_init_opensearch_client test case seems to be failing.

julian-risch
julian-risch approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for the quick fix and the additional test. Still wondering how we didn't notice the issue earlier though. Maybe something to discuss in our retro meeting.

@ZanSara ZanSara merged commit f3e0ba4 into master May 5, 2022
@ZanSara ZanSara deleted the opensearch_space_type_to_similarity branch May 5, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
topic:document_store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initialising an OpenSearchDocumentStore results in an error
2 participants
@ZanSara @julian-risch