-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and use delete_index instead of delete_documents in tests #2453
Conversation
Hey @tstadel could you please briefly explain what's the problem with deleting just the documents and not the index in the tests? Is there any specific problem you came across? |
I updated the description above to answer it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. 👍 The many failing tests are worrying though. Please check that before merging, thanks. Seems all related to pymilvus.
…k into delete_index_in_tests
To reset the document store for tests
delete_index
is cleaner thandelete_documents
as the latter does not remove properties that have been selected at index creation time (e.g. field mapping, embedding dimensions, similarity spaces). Additionally fixturedocument_store
implements index deletion on its own for Milvus and Pinecone.This PR facilitates and standardizes index cleaning in tests.
Proposed changes:
delete_index
instead ofdelete_documents
in testsdelete_index
for all document storesrecreate_index
param to Pincone, Milvus and WeaviateStatus (please check what you already did):