Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added macos version of xpdf in tutorial 8 #2424

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Added macos version of xpdf in tutorial 8 #2424

merged 2 commits into from
Apr 14, 2022

Conversation

seduerr91
Copy link
Contributor

Proposed changes:

  • I added two lines to download xpdf for the mac version, so that the pdftotext converter can be used and preprocssed
  • The additional code is 'commented out'

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

Thank you.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@brandenchan brandenchan self-requested a review April 14, 2022 13:30
brandenchan
brandenchan approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@brandenchan brandenchan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for these changes!

@brandenchan brandenchan merged commit 3d42b70 into deepset-ai:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandenchan brandenchan brandenchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seduerr91 @brandenchan