New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Auth token not passed for EmbeddingRetriever #2404

Merged

mathislucka merged 2 commits into master from fix_auth_token_for_embedding_retriever

Apr 11, 2022

Member

mathislucka commented Apr 11, 2022

Proposed changes:

The auth token for HF private models is not passed to the EmbeddingRetriever initialization.

Status (please check what you already did):

First draft (up for discussions & feedback)
[ x] Final code
Added tests
Updated documentation

mathislucka and others added 2 commits

April 11, 2022 16:22


          passing auth token allows to access private models


          Update Documentation & Code Style

00ebd1e

ZanSara approved these changes

View reviewed changes

Contributor

ZanSara left a comment

LGTM 👍

mathislucka merged commit 5ac5b4e into master

mathislucka deleted the fix_auth_token_for_embedding_retriever branch

April 11, 2022 15:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet