Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce num REST API workers to accommodate smaller machines #2400

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Reduce num REST API workers to accommodate smaller machines #2400

merged 2 commits into from
Apr 11, 2022

Conversation

brandenchan
Copy link
Contributor

Proposed changes:
Reduces number of REST API workers from 8 to 2 to reduce memory consumption of the REST API docker. This is in response to #2399

@brandenchan brandenchan requested review from tstadel and ZanSara April 11, 2022 09:35
tstadel
tstadel approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You could extend the comment a bit to give a little more guidance here by addressing when it makes sense to increase/ decrease the number of workers.

@brandenchan brandenchan merged commit 4ef099d into master Apr 11, 2022
@brandenchan brandenchan deleted the rest_api_workers branch April 11, 2022 11:26
@ZanSara ZanSara removed their request for review September 1, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstadel tstadel tstadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandenchan @tstadel