Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table extraction in ParsrConverter #2262

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

bogdankostic
Copy link
Contributor

This PR fixes the table extraction of the ParsrConverter. Previously, the number of columns was determined on the number of columns in the first row. However, due to merged cells, the number of columns can be larger in the following rows. The number of columns is now determined based on the max number of cells of each row.

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! 👍 In general, edge cases regarding the format of input data might be something we would like to have covered by our tests.

@bogdankostic bogdankostic merged commit a5501c7 into master Mar 2, 2022
@bogdankostic bogdankostic deleted the fix_parsr_converter branch March 2, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants