-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Pipeline peripherals #2253
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements! Also very happy about the tests 🤩 I left a few comments for some improvements here and there, but mostly minor stuff.
I just wished I was more explicit when I said where exactly I was going to mess with the Pipeline loading and validation part, because these changes are going to result in a hot mess of merge conflicts with my Pipeline validation PR 🥲 I'd rather merge yours first, mine is not ready yet: but I might need some help to deal with the damage later 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just learned about the match
parameter of pytest.raises()
, I'm going to make use of it!
Proposed changes:
pipelines.config
pipelines.utils
Pipeline
import into_code
Pipeline
class, interfaces are pipeline_config or networkx graphStatus (please check what you already did):