Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate JSON schema index for Schemastore #2225

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Feb 21, 2022

Related to #2110.

Proposed changes:

  • As noted in k3d: reference versions schema in k3d repo SchemaStore/schemastore#2057 (comment), Schemastore supports schema indices hosted remotely. They will allow us to be in control of the versioning of our schemas without the need to submit a PR to them every time we release a new schema version.
  • Said index is generated in the CI and will always have at most one rc version in it (to avoid pollution). They're unstable anyway (they get overwritten at every push to master) so I don't think they should stay in the index once they become obsolete.
  • This change also fixes the (currently failing) CI 😅

Status:

@ZanSara ZanSara requested a review from julian-risch February 21, 2022 15:11
@ZanSara ZanSara added topic:pipeline type:feature New feature or request labels Feb 21, 2022
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code-and-docs-check test is failing. Other wise looks good to me. I didn't check each of the 2590 lines of json-schemas/haystack-pipeline-1.2.0rc0.schema.jsonthough. 😉
In the issue description, the list item "Updated documentation" is still open. Feel free to merge once this is addressed.
I was thinking a bit about whether to remove any existing (unstable) rc versions from the schema index. Makes sense to me. 👍

@ZanSara ZanSara merged commit d1b7761 into master Feb 22, 2022
@ZanSara ZanSara deleted the schema_index_for_schemastore branch February 22, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:pipeline type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants