Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove substrings basic implementation #2152

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Remove substrings basic implementation #2152

merged 6 commits into from
Mar 8, 2022

Conversation

dmigo
Copy link
Member

@dmigo dmigo commented Feb 9, 2022

Relates to #2011

Proposed changes:

  • replace_substrings property for Preprocessor that allows removing substrings as a part of the pipeline

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@tholor tholor requested a review from ZanSara February 16, 2022 07:58
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left only a minor comment on the test 👍

test/test_preprocessor.py Outdated Show resolved Hide resolved
@ZanSara ZanSara added topic:preprocessing type:feature New feature or request labels Feb 24, 2022
@ZanSara ZanSara merged commit ecec9b4 into master Mar 8, 2022
@ZanSara ZanSara deleted the remove-substrings branch March 8, 2022 14:49
@dmigo
Copy link
Member Author

dmigo commented Mar 9, 2022

@ZanSara thanks for pushing this one forward, it somehow completely disappeared from my radar

@ZanSara
Copy link
Contributor

ZanSara commented Mar 9, 2022

No worries! It was basically ready for merge 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants