Add filtering by tags for InMemoryDocumentStore #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 13, 2020 00:10
tanaysoni
suggested changes
May 13, 2020
… to support {many tags with many differnt values}. Adding unit tests
tanaysoni
suggested changes
May 14, 2020
haystack/database/base.py
Outdated
| @@ -38,9 +38,14 @@ class Document(BaseModel): | |||
| question: Optional[str] = Field(None, description="Question text for FAQs.") | |||
| query_score: Optional[float] = Field(None, description="Elasticsearch query score for a retrieved document") | |||
| meta: Optional[Dict[str, Any]] = Field(None, description="") | |||
| tags: Optional[Dict[str, Any]] = Field(None, description="Tags that allow filtering of the data") | |||
|
|
|||
| def __getitem__(self, item): | |||
There was a problem hiding this comment.
Could we remove __get_item__() altogether? I think we can access PyDantic properties directly, eg., document.text and document.meta.
|
Thanks again @skirdey for the PR. It looks good-to-go! |
tanaysoni
changed the title
tanaysoni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing and filtering tags in InMemory store. Adding meta obj to InMemory store.