Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorials, utilities, tests and dependencies to run on Milvus2 #2067

Closed
ZanSara opened this issue Jan 26, 2022 · 0 comments · Fixed by #2126
Closed

Update tutorials, utilities, tests and dependencies to run on Milvus2 #2067

ZanSara opened this issue Jan 26, 2022 · 0 comments · Fixed by #2126
Labels
topic:document_store type:refactor Not necessarily visible to the users

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Jan 26, 2022

Even though Haystack supports Milvus2, right now all tutorials and utilities are somehow hardcoded to use Milvus1. Given the recent release of Milvus2, we should make sure they work properly with it, ensure the correct tests are run in the CI and default users on Milvus2.
ZanSara added a commit that referenced this issue Jan 26, 2022
@ZanSara
Update some tutorials and rever Milvus1 as default for now, see #2067
7e9ec23
ZanSara added a commit that referenced this issue Jan 26, 2022
@ZanSara @github-actions
Improve dependency management (#1994)
d470b9d 
* Fist attempt at using setup.cfg for dependency management

* Trying the new package on the CI and in Docker too

* Add composite extras_require

* Add the safe_import function for document store imports and add some try-catch statements on rest_api and ui imports

* Fix bug on class import and rephrase error message

* Introduce typing for optional modules and add type: ignore in sparse.py

* Include importlib_metadata backport for py3.7

* Add colab group to extra_requires

* Fix pillow version

* Fix grpcio

* Separate out the crawler as another extra

* Make paths relative in rest_api and ui

* Update the test matrix in the CI

* Add try catch statements around the optional imports too to account for direct imports

* Never mix direct deps with self-references and add ES deps to the base install

* Refactor several paths in tests to make them insensitive to the execution path

* Include tstadel review and re-introduce Milvus1 in the tests suite, to fix

* Wrap pdf conversion utils into safe_import

* Update some tutorials and rever Milvus1 as default for now, see #2067

* Fix mypy config


Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ZanSara ZanSara linked a pull request Jan 28, 2022 that will close this issue
Milvus 2.0.0 #2077
Closed
@ZanSara ZanSara linked a pull request Feb 11, 2022 that will close this issue
Make Milvus2DocumentStore compatible with pymilvus>=2.0.0 #2126
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:document_store type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
1 participant
@ZanSara