Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Document Store fixtures #1996

Closed
ZanSara opened this issue Jan 12, 2022 · 0 comments · Fixed by #4125
Closed

Refactor Document Store fixtures #1996

ZanSara opened this issue Jan 12, 2022 · 0 comments · Fixed by #4125
Assignees
@masci
Labels
topic:document_store topic:tests type:refactor Not necessarily visible to the users

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Jan 12, 2022

Following #1853 and #1990, the fixtures for running document stores related tests got more way more complicated to read and debug. I propose a refactoring of such fixtures and, possibly, a refactoring of DocumentStore's tests as well (most of them are very long and repetitive).

This issue is related to #1897, and might be better to address as part of the refactoring detailed there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masci masci

Labels
topic:document_store topic:tests type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: complete the document stores test refactoring deepset-ai/haystack
2 participants
@masci @ZanSara