Skip to content

Commit

Permalink
apply feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
tstadel committed Jan 7, 2025
1 parent ea69744 commit 901f17d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
15 changes: 10 additions & 5 deletions haystack/dataclasses/byte_stream.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Any, Dict, Optional


@dataclass
@dataclass(repr=False)
class ByteStream:
"""
Base data class representing a binary object in the Haystack API.
Expand Down Expand Up @@ -64,9 +64,14 @@ def to_string(self, encoding: str = "utf-8") -> str:
"""
return self.data.decode(encoding)

def __str__(self) -> str:
def __repr__(self) -> str:
"""
Returns a string representation of the ByteStream, truncating the data to 1KB.
Return a string representation of the ByteStream, truncating the data to 100 bytes.
"""
truncated = self.data[:1024] + b"..." if len(self.data) > 1024 else self.data
return f"ByteStream(data={truncated!r}, mime_type={self.mime_type!r}, meta={self.meta!r})"
fields = []
truncated_data = self.data[:100] + b"..." if len(self.data) > 100 else self.data
fields.append(f"data={truncated_data!r}")
fields.append(f"meta={self.meta!r}")
fields.append(f"mime_type={self.mime_type!r}")
fields_str = ", ".join(fields)
return f"{self.__class__.__name__}({fields_str})"
4 changes: 2 additions & 2 deletions test/dataclasses/test_byte_stream.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ def test_to_file(tmp_path, request):


def test_str_truncation():
test_str = "1234567890" * 1000
test_str = "1234567890" * 100
b = ByteStream.from_string(test_str, mime_type="text/plain", meta={"foo": "bar"})
string_repr = str(b)
assert len(string_repr) < 1200
assert len(string_repr) < 200
assert "text/plain" in string_repr
assert "foo" in string_repr

0 comments on commit 901f17d

Please sign in to comment.