Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update HF example to correct founding city #181

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: Update HF example to correct founding city #181

merged 1 commit into from
Jan 28, 2025

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 28, 2025

Related Issues

Proposed Changes:

Update example to use correct founding city for HuggingFace

How did you test it?

Locally

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner January 28, 2025 08:11
@sjrl sjrl requested review from mpangrazzi and removed request for a team January 28, 2025 08:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13006146220

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.774%
Totals Coverage Status
Change from base Build 12990383199: 0.0%
Covered Lines: 1345
Relevant Lines: 2109
💛 - Coveralls

mpangrazzi
mpangrazzi approved these changes Jan 28, 2025
View reviewed changes
Copy link

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (curiously, I was also thinking HF was founded in Paris 😁)

@sjrl sjrl merged commit 37c64d5 into main Jan 28, 2025
7 of 8 checks passed
@sjrl sjrl deleted the update-example branch January 28, 2025 08:28
@sjrl sjrl changed the title fxi: Update HF example to correct founding city fix: Update HF example to correct founding city Jan 28, 2025
mathislucka pushed a commit that referenced this pull request Jan 28, 2025
@sjrl @mathislucka
Update HF example to correct founding city (#181)
51c4399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpangrazzi mpangrazzi mpangrazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjrl @coveralls @mpangrazzi