fix: raise error on import of AsyncPipeline
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12990000451Details
💛 - Coveralls |
Amnah199
requested review from
dfokina,
mpangrazzi,
julian-risch and
davidsbatista
and removed request for
a team,
dfokina and
mpangrazzi
julian-risch
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
LGTM! 👍 For now, we'll need to pause the experiment on AsyncPipeline. As a next step, we should add a comment to the GitHub discussion about the experimental AsyncPipeline, explain that the experiment is paused, and point to 0.4.0 release. #152
Similarly, we should add a note to the cookbook or remove it entirely: https://github.com/deepset-ai/haystack-cookbook/blob/bd82aac09307379fa082e374d8855769a943b9e7/notebooks/async_pipeline.ipynb
davidsbatista
approved these changes
Jan 27, 2025
mathislucka
pushed a commit
that referenced
this pull request
Jan 28, 2025
* raise error for async import * Remove all async pipeline tests
mathislucka
pushed a commit
that referenced
this pull request
Jan 31, 2025
* raise error for async import * Remove all async pipeline tests (cherry picked from commit cbbf088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
RuntimeErrorwhen the user tries to initialize async pipelines in 0.5.0 release.How did you test it?
Ran code manually
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.