Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make Ollama testing workflow more robust #1355

Merged
merged 14 commits into from
Feb 6, 2025
Merged

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 5, 2025

Related Issues

Proposed Changes:

After some attempts, I decide to make this testing workflow more structured and robust:

  • separate Ollama installation and model pulling
  • add a retry mechanism for these different steps: if they fail, it's not possible that python tests will pass
  • (python tests already have a retry mechanism)

How did you test it?

CI
if you look at latest CI runs, you'll notice that the pulling step sometimes failed and has been retried

Checklist

@anakin87 anakin87 changed the title use ollama 0.5.5 ci: make Ollama testing workflow more robust Feb 5, 2025
@anakin87 anakin87 marked this pull request as ready for review February 5, 2025 17:54
@anakin87 anakin87 requested a review from a team as a code owner February 5, 2025 17:54
@anakin87 anakin87 requested review from Amnah199 and removed request for a team February 5, 2025 17:54
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, it looks good.

@anakin87 anakin87 merged commit 944d225 into main Feb 6, 2025
6 checks passed
@anakin87 anakin87 deleted the fix-ollama-tests branch February 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants