Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip tests when only CHANGELOG.md is modified #1347

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 3, 2025

Related Issues

After #1330, every time we release a new integration, a PR with the proposed CHANGELOG change is opened and tests run on it, wasting time and computational resources.

Proposed Changes:

  • for each integration, do not run tests if only CHANGELOG.md is modified

How did you test it?

Not easy to test before merging.
Some tests failures are unrelated to this PR.

Checklist

@anakin87 anakin87 marked this pull request as ready for review February 3, 2025 15:35
@anakin87 anakin87 requested a review from a team as a code owner February 3, 2025 15:35
@anakin87 anakin87 requested review from davidsbatista and removed request for a team February 3, 2025 15:35
@davidsbatista
Copy link
Contributor

nice 👍🏽

(nit: It may also be worth to add a similar rule for README.md?)

btw: nvidia is failing due to Authorization error - I will try to investigate still today

@anakin87
Copy link
Member Author

anakin87 commented Feb 4, 2025

(nit: It may also be worth to add a similar rule for README.md?)

Good idea! I will exclude all .md files in the root folder of each integration.

@anakin87 anakin87 merged commit 4503e4a into main Feb 4, 2025
154 of 162 checks passed
@anakin87 anakin87 deleted the skip-tests-changelog branch February 4, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment