Client Reject Incompatible models #1056
Open
+576
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
…grations into raspawar/reject_incomp_model
…pawar/haystack-core-integrations into raspawar/reject_incomp_model
|
@mattf ptal |
…pawar/haystack-core-integrations into raspawar/reject_incomp_model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user of the connectors, I can select from many modals and want to be alerted early if a model is not compatible with my use case.
Example test, w/ public_class of NvidiaGenerator, NvidiaTextEmbedder, NvidiaDocumentEmbedder for HayStack -
invalid = select known model that does not work with public_class, e.g. NV-Embed-QA and NvidiaGenerator
public_class(model=invalid, nvidia_api_key="a-bogus-key")
cc: @sumitkbh @mattf