Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Add component class factory #62

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Add component class factory #62

merged 1 commit into from
Aug 2, 2023

Conversation

silvanocerza
Copy link
Contributor

Add a utility function to create custom components for testing purposes.

Some factory tests will fail as I discovered some issues with I/O definition that I'll fix in another PR. I'll rebase this one after they're fixed.

@silvanocerza silvanocerza requested a review from masci July 27, 2023 14:49
@silvanocerza silvanocerza self-assigned this Jul 27, 2023
@silvanocerza silvanocerza force-pushed the components-factory branch 2 times, most recently from f13aa2f to d5f3252 Compare August 2, 2023 13:38
@silvanocerza silvanocerza changed the base branch from main to split-io-magic-fields August 2, 2023 13:43
Base automatically changed from split-io-magic-fields to main August 2, 2023 13:51
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good idea adding it to testing so we can use it from Haystack's tests

@silvanocerza silvanocerza merged commit 319f82a into main Aug 2, 2023
@silvanocerza silvanocerza deleted the components-factory branch August 2, 2023 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants