Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS build script #783

Closed
deepnight opened this issue Jan 2, 2023 · 2 comments
Closed

Fix macOS build script #783

deepnight opened this issue Jan 2, 2023 · 2 comments
Labels
🪳 Bug Something isn't working 🙋‍♂️ Help wanted Extra attention is needed
Milestone
1.2.1

Comments

@deepnight
Copy link
Owner

deepnight commented Jan 2, 2023 •
edited
Loading

YML script: https://github.com/deepnight/ldtk/blob/master/.github/workflows/package-macos.yml
GitHub action: https://github.com/deepnight/ldtk/actions/workflows/package-macos.yml
@deepnight deepnight added 🪳 Bug Something isn't working 🙋‍♂️ Help wanted Extra attention is needed labels Jan 2, 2023
@deepnight deepnight added this to the 1.2.1 milestone Jan 2, 2023
@keithclark
Copy link
Contributor

The build error suggests that python is missing.

Looks like Python 2 was removed from OSX in 12.3 and the Github action is running in OSX 12.6.2.

This similar issue suggests updating electron-builder may fix the problem: electron-userland/electron-builder#6606

@stephenmuss stephenmuss mentioned this issue Jan 3, 2023
Closed
deepnight added a commit that referenced this issue Jan 3, 2023
@deepnight
Increased electron builder version to fix macOS build (#783)
c4075e9
@deepnight
Copy link
Owner Author

Fixed in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 Bug Something isn't working 🙋‍♂️ Help wanted Extra attention is needed
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Update electron-builder to fix MacOS build issue stephenmuss/ldtk
2 participants
@keithclark @deepnight