fix type hints errors; add type checker #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses microsoft/pyright as a type checker. Several errors have been fixed. Sometimes the type of a varible is too "dynamic". It will be helpful to use `assert` to narrow types. Finally, one can add `# type: ignore` to skip type checker of a line.
Codecov ReportBase: 75.51% // Head: 75.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 75.51% 75.48% -0.04%
==========================================
Files 62 62
Lines 2618 2631 +13
==========================================
+ Hits 1977 1986 +9
- Misses 641 645 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dpgen2/fp/vasp.py
Outdated
| @@ -37,7 +38,10 @@ def __init__( | |||
| """ | |||
| self.kspacing = kspacing | |||
| self.kgamma = kgamma | |||
| # TODO: not acctually optional | |||
There was a problem hiding this comment.
I agree with you. Could you please remove the Optional of the incar_template_name and potcar_names? Thanks!
| @@ -41,7 +41,7 @@ def __init__( | |||
| run_train_op : OP, | |||
| prep_config : dict = normalize_step_dict({}), | |||
| run_config : dict = normalize_step_dict({}), | |||
| upload_python_package : str = None, | |||
| upload_python_package : Optional[List[os.PathLike]] = None, | |||
There was a problem hiding this comment.
Should be list but used by dpgen2 as a str. Will be fixed by a separate PR.
wanghan-iapcm
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses microsoft/pyright as a type checker. Several errors have been fixed.
Sometimes the type of a variable is too "dynamic". It will be helpful to use
assertto narrow the types. Finally, one can add# type: ignoreto skip the type checking of a line.