migrate from setup.py to pyproject.toml #86
Conversation
Codecov ReportBase: 67.28% // Head: 67.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 67.28% 67.16% -0.13%
==========================================
Files 59 59
Lines 2467 2467
==========================================
- Hits 1660 1657 -3
- Misses 807 810 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pyproject.toml
Outdated
| ] | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ["dpgen2"] |
There was a problem hiding this comment.
Use dpgen2* to match submodules (e.g. dpgen2.entrypoint). Otherwise only dpgen2 is matched.
There was a problem hiding this comment.
dpgen2/.github/workflows/test.yml
Line 22 in 8589a93
The current behavior is testing the package without installing it.
We may:
- install the package.
- restore requirement.txt, and find someway of using it in pyproject.toml, just like the what the setup.py does.
What do you think?
There was a problem hiding this comment.
I prefer pip install -e . in editable mode. There is also a funny workaround in pypa/pip#8049 (comment).
|
@njzjz could you please help fixing the issue in the doc building? thanks! |
pyproject.toml
Outdated
| docs = [ | ||
| 'sphinx', | ||
| 'recommonmark', | ||
| 'sphinx_rtd_theme>=1.0.0rc1', | ||
| 'numpydoc', | ||
| 'm2r2', | ||
| 'deepmodeling-sphinx>=0.1.1', | ||
| 'sphinx-argparse', | ||
| ] |
There was a problem hiding this comment.
These are different from setup.py...
as deepmodeling#86 requires setuptools 61
as #86 requires setuptools 61
No description provided.