Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactorize ExplorationTaskGroup. #187

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

wanghan-iapcm
Copy link

@wanghan-iapcm wanghan-iapcm commented Feb 2, 2024

  • implement exploration task group in a separate file.
  • provide abs method make_task. all exploration task group should implement the method.
  • provide BaseExplorationTaskGroup as a data holder

…de ExplorationTaskGroupData as a data holder
@wanghan-iapcm wanghan-iapcm requested a review from zjgemi February 2, 2024 03:19
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ebe7a17) 87.44% compared to head (74873cb) 87.56%.
Report is 5 commits behind head on master.

Files Patch % Lines
dpgen2/exploration/task/task_group.py 75.51% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   87.44%   87.56%   +0.12%     
==========================================
  Files          82       83       +1     
  Lines        4173     4183      +10     
==========================================
+ Hits         3649     3663      +14     
+ Misses        524      520       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjgemi zjgemi merged commit c0f1973 into deepmodeling:master Feb 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants