Fix bugs #107
Merged
Fix bugs #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghan-iapcm
commented
Dec 29, 2022
wanghan-iapcm
commented
- init_data_sys can be str
- not overwriting the batch size in dp input script
- update dependencies.
njzjz
approved these changes
Dec 29, 2022
njzjz
reviewed
Dec 29, 2022
dpgen2/op/run_dp_train.py
Outdated
Comment on lines
199
to
200
| if odict['training']['training_data'].get('batch_size') is None: | ||
| odict['training']['training_data']['batch_size'] = "auto" |
There was a problem hiding this comment.
Use dict.setdefault.
Suggested change
| if odict['training']['training_data'].get('batch_size') is None: | |
| odict['training']['training_data']['batch_size'] = "auto" | |
| odict['training']['training_data'].setdefault('batch_size', "auto") |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 69 69
Lines 2903 2903
=======================================
Hits 2354 2354
Misses 549 549 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.