Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor configurations #103

Merged
merged 8 commits into from
Dec 22, 2022
Merged

Conversation

wanghan-iapcm
Copy link

@wanghan-iapcm wanghan-iapcm commented Dec 21, 2022

  • new module conf is provided.
  • create abstract base class conf.ConfGenerator
  • all the configuration definitions are derived from the conf.ConfGenerator
  • examples of conf.AlloyConfGenerator and conf.FileConfGenerator are provided. The former generate alloy configurations, and the latter generates confs from files.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz December 21, 2022 14:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Attention: Patch coverage is 94.39252% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (db4ea65) to head (fe3265d).
Report is 140 commits behind head on master.

Files with missing lines Patch % Lines
dpgen2/entrypoint/submit.py 33.33% 4 Missing ⚠️
dpgen2/conf/conf_generator.py 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   71.81%   80.94%   +9.12%     
==========================================
  Files          65       68       +3     
  Lines        2743     2829      +86     
==========================================
+ Hits         1970     2290     +320     
+ Misses        773      539     -234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm requested a review from njzjz December 22, 2022 03:34
@wanghan-iapcm wanghan-iapcm merged commit ea66892 into deepmodeling:master Dec 22, 2022
@wanghan-iapcm wanghan-iapcm deleted the refact-conf branch December 22, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants