Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility of autotest module with latest pymatgen>2022.7.19 #963

Merged
merged 13 commits into from
Oct 6, 2022

Conversation

ZLI-afk
Copy link
Contributor

@ZLI-afk ZLI-afk commented Sep 21, 2022

Fix incompatibility of Interstitial.py and Vacancy.py with pymatgen>2022.7.9
add pymatgen-analysis-defect and pybind11 in setup.py.
add reminder for user to install pymatgen-analysis-defect if this package is not in their environment

@ZLI-afk ZLI-afk closed this Sep 22, 2022
@ZLI-afk ZLI-afk reopened this Sep 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Base: 38.15% // Head: 38.40% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (81d3690) compared to base (403d42d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #963      +/-   ##
==========================================
+ Coverage   38.15%   38.40%   +0.24%     
==========================================
  Files          99       99              
  Lines       17889    17944      +55     
==========================================
+ Hits         6826     6891      +65     
+ Misses      11063    11053      -10     
Impacted Files Coverage Δ
dpgen/auto_test/Interstitial.py 63.84% <100.00%> (+0.59%) ⬆️
dpgen/auto_test/Vacancy.py 52.50% <100.00%> (+0.60%) ⬆️
dpgen/generator/lib/parse_calypso.py 84.37% <0.00%> (-0.48%) ⬇️
dpgen/generator/run.py 61.89% <0.00%> (-0.06%) ⬇️
dpgen/auto_test/lib/lmp.py 0.00% <0.00%> (ø)
dpgen/tools/auto_gen_param.py 0.00% <0.00%> (ø)
dpgen/dispatcher/DispatcherList.py 0.00% <0.00%> (ø)
dpgen/generator/lib/run_calypso.py 10.03% <0.00%> (+0.03%) ⬆️
dpgen/data/gen.py 47.91% <0.00%> (+0.04%) ⬆️
dpgen/dispatcher/Slurm.py 8.53% <0.00%> (+0.05%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the docs should bump the Python version. See https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python

dpgen/auto_test/Interstitial.py Outdated Show resolved Hide resolved
tests/auto_test/test_vacancy.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HuangJiameng HuangJiameng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title be 2022.7.19?

@ZLI-afk ZLI-afk changed the title Fix incompatibility of autotest module with latest pymatgen>2022.7.9 Fix incompatibility of autotest module with latest pymatgen>2022.7.19 Sep 22, 2022
@ZLI-afk
Copy link
Contributor Author

ZLI-afk commented Sep 22, 2022

My mistake. already fixed, thanks

@HuangJiameng
Copy link
Collaborator

@njzjz Do you know how to change the python version to >=3.8 when building readthedocs in checks?

@njzjz
Copy link
Member

njzjz commented Sep 22, 2022

@njzjz Do you know how to change the python version to >=3.8 when building readthedocs in checks?

See https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python

@HuangJiameng
Copy link
Collaborator

@njzjz Do you know how to change the python version to >=3.8 when building readthedocs in checks?

See https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python

Hmm...Where is environment.yml ?

@njzjz
Copy link
Member

njzjz commented Sep 23, 2022

@njzjz Do you know how to change the python version to >=3.8 when building readthedocs in checks?

See https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python

Hmm...Where is environment.yml ?

If you mean .readthedocs.yml, you need to add it to the root directory. There is an example on that page.

@HuangJiameng
Copy link
Collaborator

HuangJiameng commented Sep 26, 2022

@wanghan-iapcm Due to changes in pymatgen, we will not be able to support python versions below 3.8, which is against the rules. But it seems that there is no better way. Please check it.

setup.py Outdated Show resolved Hide resolved
@wanghan-iapcm
Copy link
Contributor

@wanghan-iapcm Due to changes in pymatgen, we will not be able to support python versions below 3.8, which is against the rules. But it seems that there is no better way. Please check it.

I agree to upgrade the python version requirement of this project to >= 3.8

dpgen/auto_test/Interstitial.py Outdated Show resolved Hide resolved
dpgen/auto_test/Interstitial.py Outdated Show resolved Hide resolved
dpgen/auto_test/Interstitial.py Show resolved Hide resolved
dpgen/auto_test/Vacancy.py Outdated Show resolved Hide resolved
delete pybind11 from setup.py
Copy link
Collaborator

@HuangJiameng HuangJiameng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the SyntaxError.

@wanghan-iapcm wanghan-iapcm merged commit 1e03bb9 into deepmodeling:devel Oct 6, 2022
njzjz added a commit to njzjz/dpgen that referenced this pull request Oct 31, 2022
wanghan-iapcm pushed a commit that referenced this pull request Nov 1, 2022
@AnguseZhang
Copy link
Collaborator

If we let DP-GEN not support python 3.7 anymore, we should update DP-GEN to 0.11.0

@njzjz njzjz linked an issue Nov 18, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dpgen cannot be installed
6 participants