-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incompatibility of autotest module with latest pymatgen>2022.7.19 #963
Conversation
add reminder for user to install pymatgen-analysis-defect if this package is not in their environment.
Codecov ReportBase: 38.15% // Head: 38.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #963 +/- ##
==========================================
+ Coverage 38.15% 38.40% +0.24%
==========================================
Files 99 99
Lines 17889 17944 +55
==========================================
+ Hits 6826 6891 +65
+ Misses 11063 11053 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the docs should bump the Python version. See https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the title be 2022.7.19?
My mistake. already fixed, thanks |
@njzjz Do you know how to change the python version to >=3.8 when building readthedocs in checks? |
See https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python |
Hmm...Where is |
If you mean |
@wanghan-iapcm Due to changes in pymatgen, we will not be able to support python versions below 3.8, which is against the rules. But it seems that there is no better way. Please check it. |
I agree to upgrade the python version requirement of this project to >= 3.8 |
delete pybind11 from setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the SyntaxError
.
considering deepmodeling#963
If we let DP-GEN not support python 3.7 anymore, we should update DP-GEN to 0.11.0 |
Fix incompatibility of Interstitial.py and Vacancy.py with pymatgen>2022.7.9
add pymatgen-analysis-defect and pybind11 in setup.py.
add reminder for user to install pymatgen-analysis-defect if this package is not in their environment