Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correct confs for fp with merge_traj #958

Closed

Conversation

HuangJiameng
Copy link
Collaborator

Fix #957

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Merging #958 (882f774) into devel (403d42d) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##            devel     #958   +/-   ##
=======================================
  Coverage   38.15%   38.15%           
=======================================
  Files          99       99           
  Lines       17889    17891    +2     
=======================================
+ Hits         6826     6827    +1     
- Misses      11063    11064    +1     
Impacted Files Coverage Δ
dpgen/generator/run.py 61.94% <50.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@AnguseZhang AnguseZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason that unit-test couldn't detect the error? Should we add a unit-test to avoid such problem?

@HuangJiameng
Copy link
Collaborator Author

#961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants