fix bug of not finding fp_params #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #842 +/- ##
==========================================
- Coverage 36.10% 36.08% -0.02%
==========================================
Files 97 97
Lines 17161 17169 +8
==========================================
Hits 6196 6196
- Misses 10965 10973 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. |
hongriTianqi
changed the title
njzjz
changed the title
wanghan-iapcm
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug when running a real calculation: fp_params not found when generating forward files. The reason is that kspacing can only found in fp_params, and I deleted the lines for getting fp_params. This bug is fixed in this PR.