-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gamma line calculation for bcc and fcc #801
Conversation
* fix ‘post_fp_cp2k’, add param rfailed * Update run.py
add gamma-line calculations for bcc and fcc
Codecov Report
@@ Coverage Diff @@
## devel #801 +/- ##
==========================================
+ Coverage 33.91% 35.53% +1.61%
==========================================
Files 93 97 +4
Lines 16562 17077 +515
==========================================
+ Hits 5617 6068 +451
- Misses 10945 11009 +64
Continue to review full report at Codecov.
|
fix left-hand coords bugs of fcc 110 direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear contributors,
There are five points maybe needed for further consideration:
1.dpgen/auto_test/Gamma.py
, the "min" in the key of parameters "min_super_cell_size" seems not intuitive, which key just refers to the replication times in three dimensions of the super-cell with respect to the primitive cell. (had communicated with the contributor)
2.dpgen/auto_test/Gamma.py
, the function __gen_slab_pmg
is defined but is not called elsewhere, seem to be a dangling function for the time being. If it is prepared for further developments in future pr, adding some comments maybe more friendly to other developers/code_readers.
3.POTCAR
files should bot be uploaded for copyrights limitation
4.for giving the example and unitest, Maybe OUTCAR
files could be uploaded instead, and corresponding test of post process could be added into the unitest.
5.dpgen/auto_test/Lammps.py
, the default convergence criteria for lammps tasks are changed into force-dependent-only, which may influence all other properties in auto-test. Please add a comment explaining the consideration of this revise.
Please checkout a new branch and make a new PR for the cohesive energy line. @kevinwenminion |
Dear reviewers, Problems 1-4 have been solved and the unitest for gamma-line post for lmp calculation has been added. For the last question, when relaxing the supercell with many atoms, force convergence is much more robust than energy convergence. From our experience, the force convergence of 1e-10 for DP should be OK in most situations. Thanks a lot for your careful review and time. |
Thanks for the contributions! But there're so many output files, are they necessary? |
add gamma line calculation for bcc and fcc.
should be no problem for bcc {110}, {112}, and {123} planes along <111>/2 direction; fcc {111} plane along <1-10>/2 and <11-2>/2 directions.