upgrade all tasks to dpdispatcher #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades init_reaction and init_surf to use dpdispatcher
Codecov Report
@@ Coverage Diff @@
## devel #749 +/- ##
==========================================
+ Coverage 33.91% 34.39% +0.47%
==========================================
Files 93 93
Lines 16562 16771 +209
==========================================
+ Hits 5617 5768 +151
- Misses 10945 11003 +58
Continue to review full report at Codecov.
|
AnguseZhang
reviewed
Jun 8, 2022
| errlog : str, default=err | ||
| path to log from stderr | ||
| api_version : str, default=0.9 | ||
| API version. 1.0 is recommended |
There was a problem hiding this comment.
Do you think that we should upgrade the default to 1.0 ?
There was a problem hiding this comment.
Upgrading to 1.0 is a breaking change, so we should do it only before the release of DP-GEN 1.0.0.
wanghan-iapcm
approved these changes
Jun 9, 2022
ZLI-afk
pushed a commit
to ZLI-afk/dpgen
that referenced
this pull request
Jul 4, 2022
* upgrade all tasks to dpdispatcher This commit upgrades init_reaction and init_surf to use dpdispatcher * fix method args * fix typo * change the variable name from `work_dir` to `work_path`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades init_reaction and init_surf to use dpdispatcher