Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jax backend #1671

Merged
merged 2 commits into from
Nov 23, 2024
Merged

feat: support jax backend #1671

merged 2 commits into from
Nov 23, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 15, 2024

Summary by CodeRabbit

  • New Features
    • Added support for the "jax" backend, allowing users to work with model files using the new .savedmodel suffix.
  • Bug Fixes
    • Updated error messages to include "jax" in the list of supported backends, improving clarity for users encountering unsupported backend issues.

Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request involve modifications to the _get_model_suffix function in the dpgen/generator/run.py file. The update adds support for the "jax" backend, including a new suffix mapping for model files. The previous mappings for "tensorflow" and "pytorch" remain unchanged, while the error message for unsupported backends has been updated to include "jax". No other aspects of the code have been altered.

Changes

File Path Change Summary
dpgen/generator/run.py Updated _get_model_suffix to add support for "jax" with suffix .savedmodel. Modified error message for unsupported backends.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Backend
    participant ModelSuffix

    User->>ModelSuffix: Request model suffix for "jax"
    ModelSuffix->>Backend: Check backend type
    Backend-->>ModelSuffix: Return suffix ".savedmodel"
    ModelSuffix-->>User: Provide suffix ".savedmodel"
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 10b9399 and e2af938.

📒 Files selected for processing (1)
  • dpgen/generator/run.py (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • dpgen/generator/run.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c2db0fa and 10b9399.

📒 Files selected for processing (1)
  • dpgen/generator/run.py (5 hunks)
🔇 Additional comments (1)
dpgen/generator/run.py (1)

132-138: LGTM! Support for JAX backend added correctly.

The changes properly add JAX backend support with the ".savedmodel" suffix and update the error message accordingly.

dpgen/generator/run.py Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz changed the title feat: support jax backend in advance feat: support jax backend Nov 16, 2024
@njzjz njzjz closed this Nov 23, 2024
@njzjz njzjz reopened this Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 49.51%. Comparing base (c2db0fa) to head (e2af938).
Report is 4 commits behind head on devel.

Files with missing lines Patch % Lines
dpgen/generator/run.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1671      +/-   ##
==========================================
- Coverage   49.58%   49.51%   -0.08%     
==========================================
  Files          83       83              
  Lines       14816    14859      +43     
==========================================
+ Hits         7347     7357      +10     
- Misses       7469     7502      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@njzjz njzjz enabled auto-merge (squash) November 23, 2024 07:21
@njzjz njzjz merged commit eecac81 into deepmodeling:devel Nov 23, 2024
7 of 10 checks passed
@njzjz njzjz deleted the jax branch November 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants