Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abacus): do not write to deepmd raw/npy, if no abacus data in post_fp_abacus_scf() #1153

Merged
merged 5 commits into from
Mar 19, 2023

Conversation

pxlxingliang
Copy link
Contributor

No description provided.

Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a UT for the case if no abacus data is generated

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (4471d17) 46.46% compared to head (9c95e7b) 46.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1153      +/-   ##
==========================================
- Coverage   46.46%   46.45%   -0.02%     
==========================================
  Files          82       82              
  Lines       14567    14564       -3     
==========================================
- Hits         6768     6765       -3     
  Misses       7799     7799              
Impacted Files Coverage Δ
dpgen/generator/run.py 65.96% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pxlxingliang
Copy link
Contributor Author

Could you please provide a UT for the case if no abacus data is generated

Ok, the unit test is added.

@wanghan-iapcm wanghan-iapcm merged commit 29a1bf8 into deepmodeling:devel Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants