Support forward files for simplify #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support "user_forward_files" for `simplify` in 02.fp step, use abspath to create symlink
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1092 +/- ##
==========================================
- Coverage 39.55% 39.54% -0.01%
==========================================
Files 99 99
Lines 17981 17986 +5
==========================================
+ Hits 7112 7113 +1
- Misses 10869 10873 +4 ☔ View full report in Codecov by Sentry. |
AnguseZhang
approved these changes
Dec 29, 2022
njzjz
reviewed
Dec 30, 2022
njzjz
approved these changes
Dec 30, 2022
|
Have you tested it? It is still not working for me. |
|
|
Are the parameters in the machine.json right? |
The correct parameter is "user_forward_files". |
It works now, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support "user_forward_files" for
simplifyin the02.fpstep. Use abspath to create symlinks to avoid unexpected problems.