Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove the reading of ntype when treating ABACUS related info #1075

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

pxlxingliang
Copy link
Contributor

The latest ABACUS 3.0.5 have removed the key word ·ntype·

@pxlxingliang
Copy link
Contributor Author

The failed unit test is caused by dpdata, I have made the similar fix in dpdata (deepmodeling/dpdata#394), We need to wait that PR to be merged and a new version of dpdata to be released.

@wanghan-iapcm
Copy link
Contributor

Dear @pxlxingliang the new version of dpdata is released https://github.com/deepmodeling/dpdata/releases/tag/0.2.13

@pxlxingliang
Copy link
Contributor Author

Dear @wanghan-iapcm, thanks!
Besides, would you please help to re-run the tests, I am not authorized to do the re-run action.

@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) December 18, 2022 04:17
@wanghan-iapcm wanghan-iapcm merged commit 2089358 into deepmodeling:devel Dec 18, 2022
@pxlxingliang pxlxingliang deleted the ntype branch January 28, 2023 03:44
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (c1937ae) to head (5b427b2).
Report is 202 commits behind head on devel.

Files Patch % Lines
dpgen/generator/lib/abacus_scf.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1075      +/-   ##
==========================================
- Coverage   39.49%   39.30%   -0.19%     
==========================================
  Files          99       99              
  Lines       17998    17976      -22     
==========================================
- Hits         7108     7066      -42     
- Misses      10890    10910      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants