-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_crd2frag: use OB native PBC implementation #1006
Conversation
The previous PBC implementation is to create ghost atoms and pass them to the OpenBabel. Since OpenBabel has supported PBC condition in v3.1.0, the previous implementation is migrated to the native one in this PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #1006 +/- ##
==========================================
+ Coverage 38.84% 39.42% +0.58%
==========================================
Files 99 99
Lines 17995 17979 -16
==========================================
+ Hits 6990 7089 +99
+ Misses 11005 10890 -115 ☔ View full report in Codecov by Sentry. |
@AnguseZhang Please check why the following test fails when open babel is installed. dpgen/tests/generator/test_gromacs_engine.py Lines 100 to 105 in e431b40
|
I've fixed the ut in this PR njzjz#108. Please check and merge in your PR.
|
The previous PBC implementation is to create ghost atoms and pass them to the OpenBabel. Since OpenBabel has supported PBC condition in v3.1.0, the previous implementation is migrated to the native one in this PR.